Tweak table block placeholder with __next40pxDefaultSize props #56935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: -114 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ec0dde8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7162888193
|
jasmussen
approved these changes
Dec 11, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
This PR introduces
__next40pxDefaultSizeprop to the placeholder input of the Table block to unify the layout.Why?
As part of an attempt to standardize the default size of components to 40px in the future.
How?
Added
__next40pxDefaultSizeprop to TextControl and Button components. At the same time, I applied gaps to the flex layout and removed many placeholder styles that were no longer needed.Testing Instructions
Screenshots or screencast
For better visual clarity, I have also included the standardized RSS block as part of #53819.
Desktop view
Before
After
Mobile view
Before
After